Follow-up r60277: Do not return BEFORE_PROCESSING, but void instead.
authorBryan Tong Minh <btongminh@users.mediawiki.org>
Thu, 29 Jul 2010 09:32:25 +0000 (09:32 +0000)
committerBryan Tong Minh <btongminh@users.mediawiki.org>
Thu, 29 Jul 2010 09:32:25 +0000 (09:32 +0000)
includes/specials/SpecialUpload.php

index ac1fd45..df2585d 100644 (file)
@@ -432,7 +432,10 @@ class SpecialUpload extends SpecialPage {
                // Deprecated backwards compatibility hook
                if( !wfRunHooks( 'UploadForm:BeforeProcessing', array( &$this ) ) ) {
                        wfDebug( "Hook 'UploadForm:BeforeProcessing' broke processing the file.\n" );
-                       return array( 'status' => UploadBase::BEFORE_PROCESSING );
+                       // Return without notifying the user of an error. This sucks, but 
+                       // this was the previous behaviour as well, and as this hook is
+                       // deprecated we're not going to do anything about it.
+                       return;
                }