Add comments and explicit check for NS_IMAGE.
authorBryan Tong Minh <btongminh@users.mediawiki.org>
Wed, 14 May 2008 11:52:59 +0000 (11:52 +0000)
committerBryan Tong Minh <btongminh@users.mediawiki.org>
Wed, 14 May 2008 11:52:59 +0000 (11:52 +0000)
includes/ImagePage.php

index 4dacae3..399fc1c 100644 (file)
@@ -44,10 +44,14 @@ class ImagePage extends Article {
        function view() {
                global $wgOut, $wgShowEXIF, $wgRequest, $wgUser;
 
-               if ( $this->img->getRedirected() ) {
+               if ( $this->mTitle->getNamespace() == NS_IMAGE && $this->img->getRedirected() ) {
                        if ( $this->mTitle->getDBkey() == $this->img->getName() ) {
+                               // mTitle is the same as the redirect target so ask Article
+                               // to perform the redirect for us.
                                return Article::view();
                        } else {
+                               // mTitle is not the same as the redirect target so it is 
+                               // probably the redirect page itself. Fake the redirect symbol
                                $wgOut->setPageTitle( $this->mTitle->getPrefixedText() );
                                $this->viewRedirect( Title::makeTitle( NS_IMAGE, $this->img->getName() ),
                                        /* $overwriteSubtitle */ true, /* $forceKnown */ true );