From 9a7c8b111281319168af5c10c1b32a8f20a99bb9 Mon Sep 17 00:00:00 2001 From: Paul Copperman Date: Wed, 4 May 2011 11:50:34 +0000 Subject: [PATCH] Remove references from function parameters in Wiki.php. They aren't needed for objects and sometimes cause warnings when called with non-vars. --- includes/Wiki.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/includes/Wiki.php b/includes/Wiki.php index 343312e9d2..b4855f30be 100644 --- a/includes/Wiki.php +++ b/includes/Wiki.php @@ -48,11 +48,11 @@ class MediaWiki { return $default; } - public function request( WebRequest &$x = null ){ + public function request( WebRequest $x = null ){ return wfSetVar( $this->context->request, $x ); } - public function output( OutputPage &$x = null ){ + public function output( OutputPage $x = null ){ return wfSetVar( $this->context->output, $x ); } @@ -67,7 +67,7 @@ class MediaWiki { * * @param $article Article */ - public function performRequestForTitle( &$article ) { + public function performRequestForTitle( $article ) { wfProfileIn( __METHOD__ ); if ( $this->context->request->getVal( 'printable' ) === 'yes' ) { @@ -267,7 +267,7 @@ class MediaWiki { * @param $context RequestContext * @return Article object */ - public static function articleFromTitle( &$title, RequestContext &$context ) { + public static function articleFromTitle( $title, RequestContext $context ) { if ( NS_MEDIA == $title->getNamespace() ) { // FIXME: where should this go? $title = Title::makeTitle( NS_FILE, $title->getDBkey() ); @@ -461,7 +461,7 @@ class MediaWiki { * * @param $article Article */ - private function performAction( &$article ) { + private function performAction( $article ) { wfProfileIn( __METHOD__ ); if ( !wfRunHooks( 'MediaWikiPerformAction', array( -- 2.20.1