From 91855f5dfc27f404608161df4c9af0d37e6b4053 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Niklas=20Laxstr=C3=B6m?= <nikerabbit@users.mediawiki.org>
Date: Wed, 14 May 2008 05:18:27 +0000
Subject: [PATCH] * Fix errors

---
 includes/SpecialNewpages.php | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/includes/SpecialNewpages.php b/includes/SpecialNewpages.php
index 7c71f7e888..d3956c4dee 100644
--- a/includes/SpecialNewpages.php
+++ b/includes/SpecialNewpages.php
@@ -30,6 +30,7 @@ class NewPagesForm {
 
 		// Options
 		$opts = new FormOptions();
+		$this->opts = $opts; // bind
 		$opts->add( 'hideliu', false );
 		$opts->add( 'hidepatrolled', false );
 		$opts->add( 'hidebots', false );
@@ -50,7 +51,6 @@ class NewPagesForm {
 		}
 
 		// Store some objects
-		$this->opts = $opts;
 		$this->skin = $wgUser->getSkin();
 		$this->title = SpecialPage::getTitleFor( 'NewPages' );
 	}
@@ -96,10 +96,10 @@ class NewPagesForm {
 		$this->showNavigation = !$including; // Maybe changed in setup
 		$this->setup( $par );
 
-		// Settings
-		$this->form();
+		if( !$including ) {
+			// Settings
+			$this->form();
 
-		if( !$including ){
 			$this->setSyndicated();
 			$feedType = $this->opts->getValue( 'feed' );
 			if( $feedType ) {
@@ -244,9 +244,9 @@ class NewPagesForm {
 		$ulink = $this->skin->userLink( $result->rc_user, $result->rc_user_text ) . ' ' .
 			$this->skin->userToolLinks( $result->rc_user, $result->rc_user_text );
 		$comment = $this->skin->commentBlock( $result->rc_comment );
-		$css = $this->patrollable( $result ) ? " class='not-patrolled'" : '';
+		$css = $this->patrollable( $result ) ? 'not-patrolled' : '';
 
-		return "<li{$css}>{$time} {$dm}{$plink} ({$hist}) {$dm}[{$length}] {$dm}{$ulink} {$comment}</li>\n";
+		return "<li class='$css'>{$time} {$dm}{$plink} ({$hist}) {$dm}[{$length}] {$dm}{$ulink} {$comment}</li>\n";
 	}
 
 	/**
-- 
2.20.1