From 8f5062a8df94a8ee75379decb6c895a70f8d4c77 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Wed, 7 May 2014 14:37:59 +0200 Subject: [PATCH] Fix i18n issue in Special:NewImages As Rillke has reported in https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Showhidebots/en the text for the check box was incorrect. It turned out to be a strange re-use of messages. Replaced it with a proper message. No re-uses in core. Remaining re-use outside of core has been taken care of in I4458ab7f6e53 Change-Id: I48042d0e60ce213db3db123179d9658cdd013a8f --- includes/specials/SpecialNewimages.php | 2 +- languages/i18n/en.json | 2 +- languages/i18n/qqq.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/specials/SpecialNewimages.php b/includes/specials/SpecialNewimages.php index 1d06071757..6891b16b07 100644 --- a/includes/specials/SpecialNewimages.php +++ b/includes/specials/SpecialNewimages.php @@ -183,7 +183,7 @@ class NewFilesPager extends ReverseChronologicalPager { ), 'showbots' => array( 'type' => 'check', - 'label' => $this->msg( 'showhidebots', $this->msg( 'show' )->plain() )->escaped(), + 'label-message' => 'newimages-showbots', 'name' => 'showbots', ), 'limit' => array( diff --git a/languages/i18n/en.json b/languages/i18n/en.json index 07d1913ec4..28fd2ae2be 100644 --- a/languages/i18n/en.json +++ b/languages/i18n/en.json @@ -2607,7 +2607,7 @@ "newimages-summary": "This special page shows the last uploaded files.", "newimages-legend": "Filter", "newimages-label": "Filename (or a part of it):", - "showhidebots": "($1 bots)", + "newimages-showbots": "Show uploads by bots", "noimages": "Nothing to see.", "ilsubmit": "Search", "bydate": "by date", diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json index 6183506213..adf6044d6b 100644 --- a/languages/i18n/qqq.json +++ b/languages/i18n/qqq.json @@ -2769,7 +2769,7 @@ "newimages-summary": "This message is displayed at the top of [[Special:NewImages]] to explain what is shown on that special page.", "newimages-legend": "Caption of the fieldset for the filter on [[Special:NewImages]]\n\n{{Identical|Filter}}", "newimages-label": "Caption of the filter editbox on [[Special:NewImages]]", - "showhidebots": "This is shown on the special page [[Special:NewImages]]. The format is \"{{int:showhidebots|[[MediaWiki:Hide/{{SUBPAGENAME}}|{{int:hide}}]]}}\" or \"{{int:showhidebots|[[MediaWiki:Show/{{SUBPAGENAME}}|{{int:show}}]]}}\"\n\n{{Identical|$1 bots}}", + "newimages-showbots": "Used as label for a checkbox. When checked, [[Special:NewImages]] will also display uploads by users in the bots group.", "noimages": "This is shown on the special page [[Special:NewImages]], when there aren't any recently uploaded files.", "ilsubmit": "Used as label for input box in the MIMESearch form on [[Special:MIMESearch]].\n\nSee also:\n* {{msg-mw|Mimesearch|page title}}\n* {{msg-mw|Mimetype|label for input box}}\n{{Identical|Search}}", "bydate": "{{Identical|Date}}", -- 2.20.1