From 8b463047a9308bf9a529eea9d764afed2c14f2e8 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Tue, 3 Nov 2015 06:05:22 +0000 Subject: [PATCH] LinkCache: Remove deprecated getBadLinks and getGoodLinks methods Deprecated since MediaWiki 1.26 (32d1017e7d). These methods contain the only remaining callers of MapCacheLRU::getAllKeys() which is the only odd method of MapCacheLRU not supported by BagOStuff. Change-Id: I64e054803595d49a5bd779accc94353924f7d87d --- RELEASE-NOTES-1.27 | 1 + includes/cache/LinkCache.php | 25 ------------------------- 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27 index 4275921e6a..f5496201cf 100644 --- a/RELEASE-NOTES-1.27 +++ b/RELEASE-NOTES-1.27 @@ -95,6 +95,7 @@ changes to languages because of Bugzilla reports. ignore the 2nd and 3rd arguments (formerly $id and $commit). * Removed "loaderScripts" option from ResourceLoaderFileModule class. * Removed ORM-like wrapper added in 1.20. +* LinkCache::getGoodLinks and LinkCache::getBadLinks were removed (deprecated in 1.26). == Compatibility == diff --git a/includes/cache/LinkCache.php b/includes/cache/LinkCache.php index 4c456869f5..93b4b57be2 100644 --- a/includes/cache/LinkCache.php +++ b/includes/cache/LinkCache.php @@ -204,31 +204,6 @@ class LinkCache { $this->mGoodLinks->clear( array( $dbkey ) ); } - - /** - * @deprecated since 1.26 - * @return array - */ - public function getGoodLinks() { - wfDeprecated( __METHOD__, '1.26' ); - $links = array(); - foreach ( $this->mGoodLinks->getAllKeys() as $key ) { - $info = $this->mGoodLinks->get( $key ); - $links[$key] = $info['id']; - } - - return $links; - } - - /** - * @deprecated since 1.26 - * @return array - */ - public function getBadLinks() { - wfDeprecated( __METHOD__, '1.26' ); - return $this->mBadLinks->getAllKeys(); - } - /** * Add a title to the link cache, return the page_id or zero if non-existent * -- 2.20.1