From 86c3feb837ef401827d1e516b32984bd0c36440a Mon Sep 17 00:00:00 2001 From: Ryan Kaldari Date: Mon, 12 Mar 2012 12:43:35 +0000 Subject: [PATCH] fix for bug 34696 - mw.loader.using shouldnt call callback more than once --- resources/mediawiki/mediawiki.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js index fbb2d7b777..eebbab21b0 100644 --- a/resources/mediawiki/mediawiki.js +++ b/resources/mediawiki/mediawiki.js @@ -611,11 +611,12 @@ var mw = ( function ( $, undefined ) { filter( 'ready', jobs[j].dependencies ), jobs[j].dependencies ) ) { - if ( $.isFunction( jobs[j].ready ) ) { - jobs[j].ready(); - } + var callback = jobs[j].ready; jobs.splice( j, 1 ); j -= 1; + if ( $.isFunction( callback ) ) { + callback(); + } } } // Execute modules whose dependencies have just been met -- 2.20.1