From 5a79a5e28c54d41873d361a9c811988b69e75389 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Mon, 1 May 2017 15:02:21 +0100 Subject: [PATCH] Remove unnecessary Function.binds Also fix ,->; typo Change-Id: Icf87ae6e2aa111f3cb578c7355c92ffc6019df55 --- .../mediawiki.special.search.commonsInterwikiWidget.js | 2 +- .../ProlepticGregorianDateTimeFormatter.js | 8 ++++---- .../src/mediawiki.widgets/mw.widgets.CalendarWidget.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/src/mediawiki.special/mediawiki.special.search.commonsInterwikiWidget.js b/resources/src/mediawiki.special/mediawiki.special.search.commonsInterwikiWidget.js index 2a93e58fa1..7e42886c5c 100644 --- a/resources/src/mediawiki.special/mediawiki.special.search.commonsInterwikiWidget.js +++ b/resources/src/mediawiki.special/mediawiki.special.search.commonsInterwikiWidget.js @@ -10,7 +10,7 @@ var resultOutput = '', i, result, imageCaption, imageThumbnailSrc; for ( i = 0; i < results.length; i++ ) { - result = results[ i ], + result = results[ i ]; imageCaption = mw.html.element( 'span', { 'class': 'iw-result__mini-gallery__caption' }, result.title ); imageThumbnailSrc = ( result.thumbnail ) ? result.thumbnail.source : ''; resultOutput += '
' + diff --git a/resources/src/mediawiki.widgets.datetime/ProlepticGregorianDateTimeFormatter.js b/resources/src/mediawiki.widgets.datetime/ProlepticGregorianDateTimeFormatter.js index 877edbaed8..0346cc1ea2 100644 --- a/resources/src/mediawiki.widgets.datetime/ProlepticGregorianDateTimeFormatter.js +++ b/resources/src/mediawiki.widgets.datetime/ProlepticGregorianDateTimeFormatter.js @@ -37,25 +37,25 @@ config.shortMonthNames = {}; $.each( config.fullMonthNames, function ( k, v ) { config.shortMonthNames[ k ] = v.substr( 0, 3 ); - }.bind( this ) ); + } ); } if ( config.shortDayNames && !config.dayLetters ) { config.dayLetters = []; $.each( config.shortDayNames, function ( k, v ) { config.dayLetters[ k ] = v.substr( 0, 1 ); - }.bind( this ) ); + } ); } if ( config.fullDayNames && !config.dayLetters ) { config.dayLetters = []; $.each( config.fullDayNames, function ( k, v ) { config.dayLetters[ k ] = v.substr( 0, 1 ); - }.bind( this ) ); + } ); } if ( config.fullDayNames && !config.shortDayNames ) { config.shortDayNames = {}; $.each( config.fullDayNames, function ( k, v ) { config.shortDayNames[ k ] = v.substr( 0, 3 ); - }.bind( this ) ); + } ); } config = $.extend( { fullMonthNames: this.constructor.static.fullMonthNames, diff --git a/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js b/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js index 57a3d9c0bc..c5a2dd416c 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js +++ b/resources/src/mediawiki.widgets/mw.widgets.CalendarWidget.js @@ -288,7 +288,7 @@ } setTimeout( function () { $bodyWrapper.addClass( 'mw-widget-calendarWidget-body-wrapper-fade-' + fade ); - }.bind( this ), 0 ); + } ); } else { this.$oldBody.replaceWith( this.$body ); } -- 2.20.1