From 5957a507e1e461b3f57b47e7ddb692733b0f46a4 Mon Sep 17 00:00:00 2001 From: Brad Jorsch Date: Mon, 18 Apr 2016 14:45:27 -0400 Subject: [PATCH] DateTimeInputWidget: Set type before calling parent constructor This way when the parent calls setValue() which calls cleanUpValue(), it cleans up the value correctly. Change-Id: I9dcfa74ca03f6aded1dd0f9593d24b0986596b41 --- .../src/mediawiki.widgets.datetime/DateTimeInputWidget.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js b/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js index 7f36137e5d..01d3442798 100644 --- a/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js +++ b/resources/src/mediawiki.widgets.datetime/DateTimeInputWidget.js @@ -55,6 +55,9 @@ config.formatter.format = '@' + config.type; } + // Early properties + this.type = config.type; + // Parent constructor mw.widgets.datetime.DateTimeInputWidget[ 'super' ].call( this, config ); @@ -64,7 +67,6 @@ OO.ui.mixin.PendingElement.call( this, config ); // Properties - this.type = config.type; this.$handle = $( '' ); this.$fields = $( '' ); this.fields = []; -- 2.20.1