From 5816c312fbdf6c01ba1de37c77f67b02e2077b60 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Wed, 3 Dec 2003 00:42:31 +0000 Subject: [PATCH] Armor against bad titles --- includes/SearchUpdate.php | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/includes/SearchUpdate.php b/includes/SearchUpdate.php index 03978bea04..87771384c2 100644 --- a/includes/SearchUpdate.php +++ b/includes/SearchUpdate.php @@ -3,26 +3,30 @@ class SearchUpdate { - /* private */ var $mId, $mNamespace, $mTitle, $mText; + /* private */ var $mId = 0, $mNamespace, $mTitle, $mText; /* private */ var $mTitleWords; function SearchUpdate( $id, $title, $text = false ) { - $this->mId = $id; - $this->mText = $text; - $nt = Title::newFromText( $title ); - $this->mNamespace = $nt->getNamespace(); - $this->mTitle = $nt->getText(); # Discard namespace + if( $nt ) { + $this->mId = $id; + $this->mText = $text; + + $this->mNamespace = $nt->getNamespace(); + $this->mTitle = $nt->getText(); # Discard namespace - $this->mTitleWords = $this->mTextWords = array(); + $this->mTitleWords = $this->mTextWords = array(); + } else { + wfDebug( "SearchUpdate object created with invalid title '$title'\n" ); + } } function doUpdate() { global $wgDBminWordLen, $wgLang, $wgDisableSearchUpdate; - if( $wgDisableSearchUpdate ) { + if( $wgDisableSearchUpdate || !$this->mId ) { return false; } $lc = SearchEngine::legalSearchChars() . "&#;"; -- 2.20.1