From: Catrope Date: Mon, 10 Sep 2012 20:15:59 +0000 (-0700) Subject: Fix fatal error in rcprop=loginfo X-Git-Tag: 1.31.0-rc.0~22396^2~1 X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=d7a50ae34cd7d288125b6665ac32e708eb763541;p=lhc%2Fweb%2Fwiklou.git Fix fatal error in rcprop=loginfo There was a recentchanges row on enwiki whose rc_params looked like array('4::tags'=>array('db-g11')), and the tag name wasn't set recursively so the inner array didn't get a tag name. This still generates invalid XML of course, because <4::tags> isn't a valid tag, but at least it doesn't fatal any more. RAWR XML GRUMBLE Change-Id: Ibb775df4bd010bdce5632914f789230d8626c9e7 --- diff --git a/includes/api/ApiQueryLogEvents.php b/includes/api/ApiQueryLogEvents.php index f2fd42519c..e3f15051cf 100644 --- a/includes/api/ApiQueryLogEvents.php +++ b/includes/api/ApiQueryLogEvents.php @@ -262,7 +262,7 @@ class ApiQueryLogEvents extends ApiQueryBase { break; } if ( !is_null( $params ) ) { - $result->setIndexedTagName( $params, 'param' ); + $result->setIndexedTagName_recursive( $params, 'param' ); $vals = array_merge( $vals, $params ); } return $vals;