From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 27 Dec 2006 23:53:18 +0000 (+0000)
Subject: * (bug 8401) Fix regression in SORBS lookup for some DNS setups
X-Git-Tag: 1.31.0-rc.0~54750
X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=b2a90d684cfa6094c84b6580a7efd2ce08a686fb;p=lhc%2Fweb%2Fwiklou.git

* (bug 8401) Fix regression in SORBS lookup for some DNS setups
The final '.' on the hostname got removed when it was moved out to a config variable.
If the local domain is a wildcard, this can lead to surprising false positives
when the lookup returns a local address instead of failure.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 6ae3e2a4ca..8d4745c417 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -420,6 +420,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   in cache key. Probably this is still a bit wonky, though. Was breaking
   parser tests when Chinese tables were getting loaded into Serbian code.
 * (bug 8380) Be nicer about blank lines in deleteBatch.php
+* (bug 8401) Fix regression in SORBS lookup for some DNS setups
 
 
 == Languages updated ==
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 3da4b44940..511bf8ff01 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -2072,7 +2072,7 @@ $wgDisableHardRedirects = false;
  * Use http.dnsbl.sorbs.net to check for open proxies
  */
 $wgEnableSorbs = false;
-$wgSorbsUrl = 'http.dnsbl.sorbs.net';
+$wgSorbsUrl = 'http.dnsbl.sorbs.net.';
 
 /**
  * Proxy whitelist, list of addresses that are assumed to be non-proxy despite what the other