From: Aaron Schulz <aschulz@wikimedia.org>
Date: Mon, 25 May 2015 18:29:34 +0000 (-0700)
Subject: Fixed regression from 97b2a1dfd with URL specified edit tags
X-Git-Tag: 1.31.0-rc.0~11283
X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=549bfc0ee5c83224c80ddad4970548092b4ffdbf;p=lhc%2Fweb%2Fwiklou.git

Fixed regression from 97b2a1dfd with URL specified edit tags

Bug: T100248
Change-Id: I2688356cd5f628dca395d1caaa82b9a5b21c025e
---

diff --git a/includes/EditPage.php b/includes/EditPage.php
index b0da562394..e88baafe56 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -1958,11 +1958,13 @@ class EditPage {
 
 		if ( $this->changeTags && isset( $doEditStatus->value['revision'] ) ) {
 			// If a revision was created, apply any change tags that were requested
-			ChangeTags::addTags(
-				$this->changeTags,
-				isset( $doEditStatus->value['rc'] ) ? $doEditStatus->value['rc']->mAttribs['rc_id'] : null,
-				$doEditStatus->value['revision']->getId()
-			);
+			$addTags = $this->changeTags;
+			$revId = $doEditStatus->value['revision']->getId();
+			// Defer this both for performance and so that addTags() sees the rc_id
+			// since the recentchange entry addition is deferred first (bug T100248)
+			DeferredUpdates::addCallableUpdate( function() use ( $addTags, $revId ) {
+				ChangeTags::addTags( $addTags, null, $revId );
+			} );
 		}
 
 		return $status;