From: Roan Kattouw <roan.kattouw@gmail.com>
Date: Mon, 25 Sep 2017 21:50:04 +0000 (-0700)
Subject: RCFilters: Also set toplinks-collapsed class if no cookie
X-Git-Tag: 1.31.0-rc.0~1956^2
X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=3dd47890b9a8202c146315b558a1e73f83bc5d6a;p=lhc%2Fweb%2Fwiklou.git

RCFilters: Also set toplinks-collapsed class if no cookie

If the cookie was not set, the PHP code treated that as
"expanded", but the JS code treated it as "collapsed".
Fix the PHP code.

Bug: T176380
Change-Id: Iff9b865bd20a571ade2ae619cbb5b3a70629003c
---

diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php
index 34a7714de2..8c2dd569cc 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -658,7 +658,8 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
 			if ( $this->isStructuredFilterUiEnabled() ) {
 				// Check whether the widget is already collapsed or expanded
 				$collapsedState = $this->getRequest()->getCookie( 'rcfilters-toplinks-collapsed-state' );
-				$collapsedClass = $collapsedState === 'collapsed' ? 'mw-rcfilters-toplinks-collapsed' : '';
+				// Note that an empty/unset cookie means collapsed, so check for !== 'expanded'
+				$collapsedClass = $collapsedState !== 'expanded' ? 'mw-rcfilters-toplinks-collapsed' : '';
 
 				$contentTitle = Html::rawElement( 'div',
 					[ 'class' => 'mw-recentchanges-toplinks-title ' . $collapsedClass ],