From: Kunal Mehta <legoktm@member.fsf.org>
Date: Tue, 12 Jul 2016 22:26:53 +0000 (-0700)
Subject: Mark Linker::link() as @deprecated
X-Git-Tag: 1.31.0-rc.0~6255
X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=2c4add9c74970f6614e9792bb50a2192dc6b635f;p=lhc%2Fweb%2Fwiklou.git

Mark Linker::link() as @deprecated

...and add a link to the on-wiki LinkRenderer documentation to the
class. Actual wfDeprecated and replacements in all the uses to come in
follow-up patches.

Change-Id: I2fefb6c38153028d2cc68c13bc62434d3df69cd2
---

diff --git a/RELEASE-NOTES-1.28 b/RELEASE-NOTES-1.28
index 780cec6863..339cbfa380 100644
--- a/RELEASE-NOTES-1.28
+++ b/RELEASE-NOTES-1.28
@@ -80,6 +80,10 @@ changes to languages because of Phabricator reports.
   login and visiting the login page while already logged in.
 * ResourceLoader::makeLoaderURL() was removed (deprecated since 1.24).
 * $.fn.liveAndTestAtStart was removed (deprecated since 1.24).
+* Linker::link() and Linker::linkKnown() were deprecated; please instead use
+  MediaWiki\Linker\LinkRenderer. In addition, the LinkBegin and LinkEnd hooks
+  were replaced by HtmlPageLinkRendererBegin and HtmlPageLinkRendererEnd
+  respectively. See docs/hooks.txt for the specific changes needed for those hooks.
 
 == Compatibility ==
 
diff --git a/includes/Linker.php b/includes/Linker.php
index 1979e44fbc..5e540b9c03 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -170,6 +170,7 @@ class Linker {
 	 * link() replaces the old functions in the makeLink() family.
 	 *
 	 * @since 1.18 Method exists since 1.16 as non-static, made static in 1.18.
+	 * @deprecated since 1.28, use MediaWiki\Linker\LinkRenderer instead
 	 *
 	 * @param Title $target Can currently only be a Title, but this may
 	 *   change to support Images, literal URLs, etc.
@@ -245,7 +246,9 @@ class Linker {
 
 	/**
 	 * Identical to link(), except $options defaults to 'known'.
+	 *
 	 * @since 1.16.3
+	 * @deprecated since 1.28, use MediaWiki\Linker\LinkRenderer instead
 	 * @see Linker::link
 	 * @return string
 	 */
diff --git a/includes/linker/LinkRenderer.php b/includes/linker/LinkRenderer.php
index 2d67b873eb..c203a16b3f 100644
--- a/includes/linker/LinkRenderer.php
+++ b/includes/linker/LinkRenderer.php
@@ -36,6 +36,7 @@ use TitleFormatter;
 /**
  * Class that generates HTML <a> links for pages.
  *
+ * @see https://www.mediawiki.org/wiki/Manual:LinkRenderer
  * @since 1.28
  */
 class LinkRenderer {