From: Alexandre Emsenhuber <ialex@users.mediawiki.org>
Date: Tue, 7 Feb 2012 19:24:31 +0000 (+0000)
Subject: Select fields returned by Revision::selectPageFields() and call Title::newFromRow... 
X-Git-Tag: 1.31.0-rc.0~24889
X-Git-Url: http://git.cyclocoop.org/%24href?a=commitdiff_plain;h=0effbbca5c778934023b4593ad30d8451fb8f481;p=lhc%2Fweb%2Fwiklou.git

Select fields returned by Revision::selectPageFields() and call Title::newFromRow() instead of Title::makeTitle() in Revision::getTitle() so that it doesn't need a separate query to load the page id or the latest revision id.
---

diff --git a/includes/Revision.php b/includes/Revision.php
index 094c271b70..445211c9b9 100644
--- a/includes/Revision.php
+++ b/includes/Revision.php
@@ -533,12 +533,12 @@ class Revision {
 		$dbr = wfGetDB( DB_SLAVE );
 		$row = $dbr->selectRow(
 			array( 'page', 'revision' ),
-			array( 'page_namespace', 'page_title' ),
+			self::selectPageFields(),
 			array( 'page_id=rev_page',
 				   'rev_id' => $this->mId ),
 			__METHOD__ );
-		if( $row ) {
-			$this->mTitle = Title::makeTitle( $row->page_namespace, $row->page_title );
+		if ( $row ) {
+			$this->mTitle = Title::newFromRow( $row );
 		}
 		return $this->mTitle;
 	}