From 90534ed5daa7f68d6d7bf349afd55f2c8295f067 Mon Sep 17 00:00:00 2001 From: Reedy Date: Tue, 12 Sep 2017 23:24:12 +0100 Subject: [PATCH] Use db query builder not raw sql Change-Id: I8e26932e28fdda9a52e0486c5d2eb269eb9ecae5 Follows-up: Ice1bdae3d16cf365da14c6df0e8d91d2b914e064 --- maintenance/populateIpChanges.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/maintenance/populateIpChanges.php b/maintenance/populateIpChanges.php index eb60f801cd..e086c5e9e6 100644 --- a/maintenance/populateIpChanges.php +++ b/maintenance/populateIpChanges.php @@ -67,12 +67,12 @@ TEXT $this->output( "Copying IP revisions to ip_changes, from rev_id $start to rev_id $end\n" ); while ( $blockStart <= $end ) { - $cond = "rev_id >= $blockStart AND rev_user = 0 ORDER BY rev_id ASC LIMIT " . $this->mBatchSize; $rows = $dbw->select( 'revision', [ 'rev_id', 'rev_timestamp', 'rev_user_text' ], - $cond, - __METHOD__ + [ "rev_id >= $blockStart", 'rev_user' => 0 ], + __METHOD__, + [ 'ORDER BY' => 'rev_id ASC', 'LIMIT' => $this->mBatchSize ] ); if ( !$rows || $rows->numRows() === 0 ) { -- 2.20.1