From 2b7230430607c90c889c6ee7c94648de14d127f3 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Sat, 9 Sep 2017 14:35:58 -0700 Subject: [PATCH] Deprecate IDatabase::implicitGroupby() Even newer mariadb versions default to only_full_group_by, putting it in the same boat as mssql, postgres, and sqlite. Change-Id: I465406e7c96ec2db1578c73d80c28ad41708c6a0 --- includes/libs/rdbms/database/IDatabase.php | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/libs/rdbms/database/IDatabase.php b/includes/libs/rdbms/database/IDatabase.php index 0283c4b48a..78889e52e0 100644 --- a/includes/libs/rdbms/database/IDatabase.php +++ b/includes/libs/rdbms/database/IDatabase.php @@ -206,6 +206,7 @@ interface IDatabase { * Returns true if this database does an implicit sort when doing GROUP BY * * @return bool + * @deprecated Since 1.30; only use grouped or aggregated fields in the SELECT */ public function implicitGroupby(); -- 2.20.1