Check for the namespace correctly in Special:Allmessages

This is a followup to I21a6d4359faf9d86ce3b01e423e8c3ab4c02658f

It fixes an error there, which causes a lot of messages
not to appear.

This checks for the namespace of the page correctly.

Change-Id: I63a34a4d674454edf9627a5893ef9dd15643f927

diff --git a/includes/specials/SpecialAllmessages.php b/includes/specials/SpecialAllmessages.php
index 33c92b5..687cbd0 100644 (file)
--- a/includes/specials/SpecialAllmessages.php
+++ b/includes/specials/SpecialAllmessages.php
@@ -272,19 +272,23 @@ class AllmessagesTablePager extends TablePager {
 
                foreach ( $res as $s ) {
                        $exists = false;
+
                        if ( $foreign ) {
-                               $title = explode( '/', $s->page_title );
-                               if ( count( $title ) === 2 && $langcode === $title[1]
-                                       && isset( $xNames[$title[0]] )
+                               $titleParts = explode( '/', $s->page_title );
+                               if ( count( $titleParts ) === 2 &&
+                                       $langcode === $titleParts[1] &&
+                                       isset( $xNames[$titleParts[0]] )
                                ) {
-                                       $exists = $title[0];
+                                       $exists = $titleParts[0];
                                }
                        } elseif ( isset( $xNames[$s->page_title] ) ) {
                                $exists = $s->page_title;
                        }
-                       if ( $exists && $s->page_namespace === NS_MEDIAWIKI ) {
+
+                       $title = Title::newFromRow( $s );
+                       if ( $exists && $title->inNamespace( NS_MEDIAWIKI ) ) {
                                $pageFlags[$exists] = true;
-                       } elseif ( $exists && $s->page_namespace === NS_MEDIAWIKI_TALK ) {
+                       } elseif ( $exists && $title->inNamespace( NS_MEDIAWIKI_TALK ) ) {
                                $talkFlags[$exists] = true;
                        }
                }