From ed96e6f1a7dadc716dce05ed6f81291d9d325972 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Fri, 11 Jan 2019 19:25:26 +0100 Subject: [PATCH] export: Mark DumpFilter::mark() as being protected I used https://codesearch.wmflabs.org/search/?q=-%3Epass%5C( to make sure there really is no other call to this. This function really is meant to be protected. I also used https://codesearch.wmflabs.org/search/?q=function%20pass%5C(&files=php to make sure I got all subclasses. Required for I7da632c43681438aa886bdb709379f10cd9cc658. Change-Id: I9aaf95c66a6efa22131de627ce015587a109858b --- includes/export/DumpFilter.php | 2 +- includes/export/DumpNamespaceFilter.php | 2 +- includes/export/DumpNotalkFilter.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/export/DumpFilter.php b/includes/export/DumpFilter.php index 088c7b19cb..75e149cea3 100644 --- a/includes/export/DumpFilter.php +++ b/includes/export/DumpFilter.php @@ -128,7 +128,7 @@ class DumpFilter { * @param object $page * @return bool */ - function pass( $page ) { + protected function pass( $page ) { return true; } } diff --git a/includes/export/DumpNamespaceFilter.php b/includes/export/DumpNamespaceFilter.php index 12b9b55eab..0b8afa216f 100644 --- a/includes/export/DumpNamespaceFilter.php +++ b/includes/export/DumpNamespaceFilter.php @@ -84,7 +84,7 @@ class DumpNamespaceFilter extends DumpFilter { * @param object $page * @return bool */ - function pass( $page ) { + protected function pass( $page ) { $match = isset( $this->namespaces[$page->page_namespace] ); return $this->invert xor $match; } diff --git a/includes/export/DumpNotalkFilter.php b/includes/export/DumpNotalkFilter.php index d99b1b1da7..c201c76b2f 100644 --- a/includes/export/DumpNotalkFilter.php +++ b/includes/export/DumpNotalkFilter.php @@ -31,7 +31,7 @@ class DumpNotalkFilter extends DumpFilter { * @param object $page * @return bool */ - function pass( $page ) { + protected function pass( $page ) { return !MWNamespace::isTalk( $page->page_namespace ); } } -- 2.20.1