From ea54ef59167e254cd7b9708a3911669a7f2bc2ab Mon Sep 17 00:00:00 2001 From: Stephane Bisson Date: Mon, 18 Sep 2017 15:07:55 -0400 Subject: [PATCH] WLFilters: always create a balanced fieldset Don't count on Xml::fieldset creating only the opening tag. Bug: T176155 Change-Id: Idc4e450c9fa03fc78a012fb5eefa60174bb1245a --- includes/specials/SpecialWatchlist.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/includes/specials/SpecialWatchlist.php b/includes/specials/SpecialWatchlist.php index 2750551bd0..8418865e10 100644 --- a/includes/specials/SpecialWatchlist.php +++ b/includes/specials/SpecialWatchlist.php @@ -635,11 +635,13 @@ class SpecialWatchlist extends ChangesListSpecialPage { 'id' => 'mw-watchlist-form' ] ); $form .= Html::hidden( 'title', $this->getPageTitle()->getPrefixedText() ); - $form .= Xml::fieldset( - $this->msg( 'watchlist-options' )->text(), - false, + $form .= Xml::openElement( + 'fieldset', [ 'id' => 'mw-watchlist-options', 'class' => 'cloptions' ] ); + $form .= Xml::element( + 'legend', null, $this->msg( 'watchlist-options' )->text() + ); if ( !$this->isStructuredFilterUiEnabled() ) { $form .= $this->makeLegend(); -- 2.20.1