From d8ca62f2784a040a2725a90450e8560f8a663424 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Sat, 14 Mar 2015 19:09:54 -0700 Subject: [PATCH] Fix phpcs errors and warnings in includes/skins Change-Id: I800f8fcd6c1ac16d0a0bd20799550de577306ded --- includes/skins/BaseTemplate.php | 3 ++- includes/skins/Skin.php | 18 ++++++++++++++---- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php index eedd2a114e..25df0f9399 100644 --- a/includes/skins/BaseTemplate.php +++ b/includes/skins/BaseTemplate.php @@ -634,7 +634,8 @@ abstract class BaseTemplate extends QuickTemplate { * debug stuff. This should be called right before outputting the closing * body and html tags. */ - function printTrail() { ?> + function printTrail() { +?> getSkin()->getContext() ); ?> html( 'bottomscripts' ); /* JS call to runBodyOnloadHook */ ?> html( 'reporttime' ) ?> diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php index 1549bbdedb..48bce6796e 100644 --- a/includes/skins/Skin.php +++ b/includes/skins/Skin.php @@ -837,9 +837,15 @@ abstract class Skin extends ContextSource { function getPoweredBy() { global $wgResourceBasePath; - $url1 = htmlspecialchars( "$wgResourceBasePath/resources/assets/poweredby_mediawiki_88x31.png" ); - $url1_5 = htmlspecialchars( "$wgResourceBasePath/resources/assets/poweredby_mediawiki_132x47.png" ); - $url2 = htmlspecialchars( "$wgResourceBasePath/resources/assets/poweredby_mediawiki_176x62.png" ); + $url1 = htmlspecialchars( + "$wgResourceBasePath/resources/assets/poweredby_mediawiki_88x31.png" + ); + $url1_5 = htmlspecialchars( + "$wgResourceBasePath/resources/assets/poweredby_mediawiki_132x47.png" + ); + $url2 = htmlspecialchars( + "$wgResourceBasePath/resources/assets/poweredby_mediawiki_176x62.png" + ); $text = 'Powered by MediaWiki'; @@ -1619,7 +1625,11 @@ abstract class Skin extends ContextSource { $result .= ']'; // Deprecated, use SkinEditSectionLinks hook instead - Hooks::run( 'DoEditSectionLink', array( $this, $nt, $section, $tooltip, &$result, $lang ), '1.25' ); + Hooks::run( + 'DoEditSectionLink', + array( $this, $nt, $section, $tooltip, &$result, $lang ), + '1.25' + ); return $result; } -- 2.20.1