From cbf0404caa43b18059abe91c74c2d536286a83b6 Mon Sep 17 00:00:00 2001 From: Daimona Eaytoy Date: Fri, 12 Apr 2019 11:17:57 +0200 Subject: [PATCH] DifferenceEngine: Use quickUserCan for display of rollback link Title::userCan is too expensive for this, as it queries the master DB just to decide whether a link should be shown. The DBPerformance warning for this is seen roughly 8000 times per day on logstash. Bug: T232258 Change-Id: I33eab493273ed4790645e338c83993043e76e1d7 --- includes/diff/DifferenceEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index 7fcda4c728..8a5caa2dce 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -544,7 +544,7 @@ class DifferenceEngine extends ContextSource { if ( $samePage && $this->mNewPage && $permissionManager->quickUserCan( 'edit', $user, $this->mNewPage ) ) { - if ( $this->mNewRev->isCurrent() && $permissionManager->userCan( + if ( $this->mNewRev->isCurrent() && $permissionManager->quickUserCan( 'rollback', $user, $this->mNewPage ) ) { $rollbackLink = Linker::generateRollback( $this->mNewRev, $this->getContext(), -- 2.20.1