From c9365a6364c9c3394663277cd10ab0e51c77d6de Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Mon, 28 Jul 2008 05:44:18 +0000 Subject: [PATCH] Revert r38068 "SpecialMovepageBeforeMove hook from Wikia codebase - allows extensions, such as spamRegex, to interfere with page moving" This passes a MovePageForm, which seems unwise. It won't apply to the edit API, and generally seems like a weak interface -- an internal UI object is passed instead of specific information, leaving it unstable to future changes. --- RELEASE-NOTES | 2 -- docs/hooks.txt | 3 --- includes/specials/SpecialMovepage.php | 4 ---- 3 files changed, 9 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index e00615746a..0f53430e3d 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -28,8 +28,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * (bug 8068) New __INDEX__ and __NOINDEX__ magic words allow user control of search engine indexing on a per-article basis. -* Added SpecialMovepageBeforeMove hook to allow extensions to interfere with - page moves (useful for blacklist-type extensions, for example) === Bug fixes in 1.14 === diff --git a/docs/hooks.txt b/docs/hooks.txt index cbd008c07f..2ef8cc97ed 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -1131,9 +1131,6 @@ $movePage: MovePageForm object $oldTitle: old title (object) $newTitle: new title (object) -'SpecialMovepageBeforeMove': Called before moving a page -&$movePage: MovePageForm object - 'SpecialPageExecuteAfterPage': called after executing a special page Warning: Not all the special pages call this hook $specialPage: SpecialPage object diff --git a/includes/specials/SpecialMovepage.php b/includes/specials/SpecialMovepage.php index 5cda361fb9..9f8bd3e89b 100644 --- a/includes/specials/SpecialMovepage.php +++ b/includes/specials/SpecialMovepage.php @@ -264,10 +264,6 @@ class MovePageForm { return; } - if( ! wfRunHooks( 'SpecialMovepageBeforeMove', array(&$this) ) ) { - return; - } - $ot = $this->oldTitle; $nt = $this->newTitle; -- 2.20.1