From 89ee3bb67ac844c0dafba46d49342e48638ec8f7 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Sun, 13 Apr 2008 20:02:50 +0000 Subject: [PATCH] No need to check if $row->rev_id is set --- includes/SpecialNewpages.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/includes/SpecialNewpages.php b/includes/SpecialNewpages.php index 8fe496d590..ea1d3d854d 100644 --- a/includes/SpecialNewpages.php +++ b/includes/SpecialNewpages.php @@ -270,13 +270,11 @@ class NewPagesForm { } protected function feedItemDesc( $row ) { - if( isset( $row->rev_id ) ) { - $revision = Revision::newFromId( $row->rev_id ); - if( $revision ) { - return '

' . htmlspecialchars( wfMsg( 'summary' ) ) . ': ' . - htmlspecialchars( $revision->getComment() ) . "

\n
\n
" . - nl2br( htmlspecialchars( $revision->getText() ) ) . "
"; - } + $revision = Revision::newFromId( $row->rev_id ); + if( $revision ) { + return '

' . htmlspecialchars( wfMsg( 'summary' ) ) . ': ' . + htmlspecialchars( $revision->getComment() ) . "

\n
\n
" . + nl2br( htmlspecialchars( $revision->getText() ) ) . "
"; } return ''; } -- 2.20.1