From 8041b1ff890b20739dbe3fb3fdacf3b7e819fb6d Mon Sep 17 00:00:00 2001 From: daniel Date: Fri, 6 Sep 2019 15:58:31 +0200 Subject: [PATCH] DifferenceEngine: show undo links for non-text content In Ia94521b78 I introduced code that would suppress undo links in diffs of non-textual content. However, extensions that define non-textual content, such as Wikibase, may override action handles to provide undo functionality. So my reasoning for removing these links was flawed. Bug: T232214 Change-Id: I0316d8c0683b0782b9940e0e1e8f70d5bcb6b468 --- includes/diff/DifferenceEngine.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index b8697e53bd..7fcda4c728 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -1511,10 +1511,6 @@ class DifferenceEngine extends ContextSource { private function userCanEdit( Revision $rev ) { $user = $this->getUser(); - if ( !$rev->getContentHandler()->supportsDirectEditing() ) { - return false; - } - if ( !$rev->userCan( RevisionRecord::DELETED_TEXT, $user ) ) { return false; } -- 2.20.1