From 7d4f219963fca224e52747ed12b6288c6d5eae2e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Niklas=20Laxstr=C3=B6m?= Date: Sat, 14 May 2011 12:24:45 +0000 Subject: [PATCH] Special pages don't have talk page. Fixes exception in feeds when using revision deletion feature: Exception: MWNamespace::getTalk does not make any sense for given namespace -1 --- includes/ChangesFeed.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/ChangesFeed.php b/includes/ChangesFeed.php index 8a17ef860b..23fb923921 100644 --- a/includes/ChangesFeed.php +++ b/includes/ChangesFeed.php @@ -161,7 +161,7 @@ class ChangesFeed { foreach( $sorted as $obj ) { $title = Title::makeTitle( $obj->rc_namespace, $obj->rc_title ); - $talkpage = $title->getTalkPage(); + $talkpage = MWNamespace::canTalk( $obj->rc_namespace ) ? $title->getTalkPage()->getFullUrl() : ''; // Skip items with deleted content (avoids partially complete/inconsistent output) if( $obj->rc_deleted ) continue; $item = new FeedItem( @@ -170,7 +170,7 @@ class ChangesFeed { $obj->rc_this_oldid ? $title->getFullURL( 'diff=' . $obj->rc_this_oldid . '&oldid=prev' ) : $title->getFullURL(), $obj->rc_timestamp, ($obj->rc_deleted & Revision::DELETED_USER) ? wfMsgHtml('rev-deleted-user') : $obj->rc_user_text, - $talkpage->getFullURL() + $talkpage ); $feed->outItem( $item ); } -- 2.20.1