From 366f3eb72b8a6a6bffbbcb928db75e50bee277d4 Mon Sep 17 00:00:00 2001 From: Platonides Date: Tue, 16 Nov 2010 15:33:29 +0000 Subject: [PATCH] Follow up r76708 1) IPTest::testValidBlocks Undefined variable: invalid in phase3/maintenance/tests/phpunit/includes/IPTest.php:174 2) IPTest::testInvalidBlocks Undefined variable: invalid in phase3/maintenance/tests/phpunit/includes/IPTest.php:197 Note that the 30.242.52.14/0 test does not pass (it is deemed a valid block) --- maintenance/tests/phpunit/includes/IPTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/maintenance/tests/phpunit/includes/IPTest.php b/maintenance/tests/phpunit/includes/IPTest.php index 3e751ad939..7d895b9aca 100644 --- a/maintenance/tests/phpunit/includes/IPTest.php +++ b/maintenance/tests/phpunit/includes/IPTest.php @@ -171,14 +171,14 @@ class IPTest extends PHPUnit_Framework_TestCase { '::fe:f:2001/1', '::6d:f:2001/8', ); - foreach ( $invalid as $i ) { + foreach ( $valid as $i ) { $this->assertTrue( IP::isValidBlock( $i ), "$i is a valid IP block" ); } } // tests isValidBlock() public function testInvalidBlocks() { - $valid = array( + $invalid = array( '116.17.184.5/33', '0.17.184.5/130', '16.17.184.1/-1', -- 2.20.1