From 2282b7c0d2239710f0a433c504cd1c0e30a4492f Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Thu, 19 Apr 2007 21:09:38 +0000 Subject: [PATCH] restore use of Revision::selectFields() removed by the recent revert; triggered a PHP notice of undefined member access per line --- includes/SpecialContributions.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/SpecialContributions.php b/includes/SpecialContributions.php index 8f342cfcdb..beb1af38f0 100644 --- a/includes/SpecialContributions.php +++ b/includes/SpecialContributions.php @@ -158,9 +158,8 @@ class ContribsFinder { $use_index = $this->dbr->useIndexClause( $index ); $sql = 'SELECT ' . 'page_namespace,page_title,page_is_new,page_latest,'. - 'rev_id,rev_page,rev_text_id,rev_timestamp,rev_comment,rev_minor_edit,rev_user,rev_user_text,'. - 'rev_deleted ' . - "FROM $page,$revision $use_index " . + join(',', Revision::selectFields()) . + " FROM $page,$revision $use_index " . "WHERE page_id=rev_page AND $userCond $nscond $offsetQuery " . 'ORDER BY rev_timestamp DESC'; $sql = $this->dbr->limitResult( $sql, $this->limit, 0 ); -- 2.20.1