From 1c881494fe25177c603e2841c6af55f2360380cc Mon Sep 17 00:00:00 2001
From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Mon, 15 Sep 2008 15:51:45 +0000
Subject: [PATCH] Clean up OldChangesListRecentChangesLine hooks some. Better
 if triggers before li tag additions.

---
 includes/ChangesList.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 8b8fd50f0c..f83ec8fe2b 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -342,7 +342,7 @@ class OldChangesList extends ChangesList {
 		$dateheader = ""; // $s now contains only <li>...</li>, for hooks' convenience.
 		$this->insertDateHeader($dateheader,$rc_timestamp);
 
-		$s = '<li>';
+		$s = '';
 
 		// Moved pages
 		if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
@@ -394,9 +394,9 @@ class OldChangesList extends ChangesList {
 			$s .= ' ' . wfMsg('number_of_watching_users_RCview',  $wgContLang->formatNum($rc->numberofWatchingusers));
 		}
 
-		$s .= "</li>\n";
-
-		wfRunHooks('OldChangesListRecentChangesLine', array(&$this, &$s, &$rc));
+		wfRunHooks( 'OldChangesListRecentChangesLine', array(&$this, &$s, $rc) );
+		
+		$s .= "<li>$s</li>\n";
 
 		wfProfileOut( $fname.'-rest' );
 
-- 
2.20.1