Aaron Schulz [Sun, 26 Aug 2007 11:16:59 +0000 (11:16 +0000)]
*Tweak message naming and content for protection notices
Aaron Schulz [Sun, 26 Aug 2007 09:49:28 +0000 (09:49 +0000)]
*Generalize function to list UI names for all groups with a permission into OutputPage::getGroupsWithPermission()
*Make a separate function in article for showing protection notice thingy on view. List out who can edit/move the page.
*Some messages added for above. Remove annoying html comment from one.
*Fix php array index errors with protection notice
Daniel Cannon [Sun, 26 Aug 2007 04:54:43 +0000 (04:54 +0000)]
(bug 10347) Added subtle message to subtitle indicating that the page currently being viewed is protected. Could perhaps be a bit more subtle by default though ...
Brion Vibber [Sat, 25 Aug 2007 22:25:17 +0000 (22:25 +0000)]
* (bug 11065) Fix regression in handling of wiki-formatted EXIF metadata
Removed a wfEscapeWikiText() in the metadata formatting code... that whole mess needs some major cleanup, though. :)
Probably escaping should happen on the _input_ somewhere in the boxels of EXIF stuff.
Aaron Schulz [Sat, 25 Aug 2007 21:25:12 +0000 (21:25 +0000)]
*Use 'USE INDEX' not 'FORCE INDEX'. Database functions seem to just ignore the later. 'USE INDEX' is outputted as 'FORCE INDEX' in the query anyway, not to mention mysql seems to use the right ones without being told.
Brion Vibber [Sat, 25 Aug 2007 20:18:56 +0000 (20:18 +0000)]
Fix for restore of image data where oldimage rows hadn't contained the various new metadata fields.
When missing on restore, metadata is re-fetched from the file and inserted into the new record in place of the empty fields.
Aaron Schulz [Sat, 25 Aug 2007 19:22:51 +0000 (19:22 +0000)]
*oi_metadata can't be null. Some fa_metadata values are NULL since there was not always an oi_metadata to use for insertion.
Brion Vibber [Sat, 25 Aug 2007 15:52:49 +0000 (15:52 +0000)]
update url in test case ref
Brion Vibber [Sat, 25 Aug 2007 15:49:36 +0000 (15:49 +0000)]
Hack a special case for regression in setting image height via box size (eg 200x200px).
The height had been simply dropped off the face of the earth, with only the width taken into account anymore.
The infrastructure for parameters doesn't seem to gracefully handle multiple values coming from one magic word match, so this is an ugly hack.
Tim Starling [Sat, 25 Aug 2007 15:15:15 +0000 (15:15 +0000)]
Optional upgrade script to populate the img_sha1 field
Tim Starling [Sat, 25 Aug 2007 13:54:12 +0000 (13:54 +0000)]
Update img_sha1 only when it's really needed, instead of in maybeUpgradeRow().
Raimond Spekking [Fri, 24 Aug 2007 08:04:51 +0000 (08:04 +0000)]
* (bug 10405) Update Farsi translations
Patch by Huji
Raimond Spekking [Fri, 24 Aug 2007 08:01:25 +0000 (08:01 +0000)]
* (bug 10367) Update Kazakh translations
Patch by AlefZet
Raimond Spekking [Fri, 24 Aug 2007 07:57:38 +0000 (07:57 +0000)]
* (bug 11020) Update Chinese translations
Patch by Shinjiman
Tim Laqua [Thu, 23 Aug 2007 22:36:54 +0000 (22:36 +0000)]
Tim Laqua [Thu, 23 Aug 2007 22:34:12 +0000 (22:34 +0000)]
Added SkinAfterBottomScripts hook to Skin::bottomScripts(), documented in hooks.txt
Rob Church [Thu, 23 Aug 2007 18:56:40 +0000 (18:56 +0000)]
General updates
Brion Vibber [Thu, 23 Aug 2007 18:28:21 +0000 (18:28 +0000)]
* Resizing transparent GIF images with GD now retains transparency by skipping
resampling
Rotem Liss [Thu, 23 Aug 2007 16:42:54 +0000 (16:42 +0000)]
Update.
Raimond Spekking [Thu, 23 Aug 2007 10:58:26 +0000 (10:58 +0000)]
Update German
Raimond Spekking [Thu, 23 Aug 2007 10:52:51 +0000 (10:52 +0000)]
Fix for r25082. Access key for preferences changed to '9'.
Access key ',' is already in use for the textarea of the edit form, but hard coded. Is there a special reason not to use the normal access key/tooltip mechanism?
Thanks to WebBoy.
Raimond Spekking [Thu, 23 Aug 2007 09:34:33 +0000 (09:34 +0000)]
* (bug 5206) Add accesskey ',' to 'preferences' navigationlink
* Add accesskey 's' and tooltip to 'upload file' button at Special:Upload
* Remove ancient hard coded [alt- ] references from message files
Raimond Spekking [Thu, 23 Aug 2007 09:04:26 +0000 (09:04 +0000)]
Revert r25080, accident commit, sorry :-(
Raimond Spekking [Thu, 23 Aug 2007 08:47:36 +0000 (08:47 +0000)]
* (bug 5206) Add accesskey ',' to 'preferences' navigationlink
* Add accesskey 's' and tooltip to 'upload file' button at Special:Upload
* Remove ancient hard coded [alt- ] references from message files
Niklas Laxström [Thu, 23 Aug 2007 07:28:05 +0000 (07:28 +0000)]
* Updates to Dutch (nl) translations
Brion Vibber [Wed, 22 Aug 2007 21:52:44 +0000 (21:52 +0000)]
Revert r25037 -- just removes functionality from Special:DoubleRedirects instead of fixing the paging problem
Brion Vibber [Wed, 22 Aug 2007 20:07:00 +0000 (20:07 +0000)]
Order of link parameters changed in r25049; putting them back so the parser test stops whining. :)
Niklas Laxström [Wed, 22 Aug 2007 17:40:26 +0000 (17:40 +0000)]
* Updates to Korean (ko) by Klutzy
Raimond Spekking [Wed, 22 Aug 2007 17:13:08 +0000 (17:13 +0000)]
* (bug 11020) Update Chinese translations
* (bug 11024) typo
Patches by Shinjiman
Tim Starling [Wed, 22 Aug 2007 16:32:10 +0000 (16:32 +0000)]
Fixed typo in LocalFileDeleteBatch::execute() which was causing complete breakage when squid was enabled.
Brion Vibber [Wed, 22 Aug 2007 16:25:07 +0000 (16:25 +0000)]
Revert r25047 -- produces confusing, useless behavior when going to Special:Upload instead of displaying the useful message that you have to enable uploads.
Raimond Spekking [Wed, 22 Aug 2007 15:58:35 +0000 (15:58 +0000)]
optional comments added, proper formatting
Rotem Liss [Wed, 22 Aug 2007 15:55:27 +0000 (15:55 +0000)]
Update.
Rotem Liss [Wed, 22 Aug 2007 15:49:31 +0000 (15:49 +0000)]
Use actual arrows, not entities.
Rob Church [Wed, 22 Aug 2007 15:05:30 +0000 (15:05 +0000)]
(bug 11013) Make sure dl() is available before attempting to use it to check available databases in installer...this detection code is quite crap and could do with some work; got a partial patch, but a few bits (the UI, JavaScript) are broken...committing this to fix the *immediate* problem
Tim Starling [Wed, 22 Aug 2007 13:40:22 +0000 (13:40 +0000)]
In ImageGallery:
* Split "is parsing" and "respect bad images" concepts.
* Call media handler parser hook
* Use the $linkAttribs parameter instead of putting an <a> tag around the whole media output.
Rob Church [Wed, 22 Aug 2007 13:28:46 +0000 (13:28 +0000)]
Tweak "invalid special page" message a bit - tempted to add, e.g. "Some special pages might be unavailable if certain software features are disabled, and some special pages are provided via extensions, and thus not available on all wikis." -- what do we think?
Rob Church [Wed, 22 Aug 2007 13:22:23 +0000 (13:22 +0000)]
(bug 11023) Don't register Special:Upload as a special page when uploads are disabled
Rob Church [Wed, 22 Aug 2007 08:55:50 +0000 (08:55 +0000)]
Whoops, fix up permission check so "deletedhistory" still works to view, etc.
Rob Church [Wed, 22 Aug 2007 08:51:56 +0000 (08:51 +0000)]
* (bug 9002) Provide a "view/restore deleted edits" link on Special:Upload when a destination filename is provided that corresponds with previous deleted files
* Fix various bits of invalid XHTML in Special:Upload
Rob Church [Wed, 22 Aug 2007 08:07:48 +0000 (08:07 +0000)]
* Fix "most viewed" heading
* Fix images in list
Rob Church [Wed, 22 Aug 2007 08:05:40 +0000 (08:05 +0000)]
* (bug 9026) Incorrect heading numbering when viewing Special:Statistics with "auto-numbered headings" enabled
* Some minor cleanup and bits of refactoring
Rob Church [Wed, 22 Aug 2007 07:24:30 +0000 (07:24 +0000)]
Tweak comment; people seem to whine about this one, not reading past the mt_rand() bit, and criticising us...
Rob Church [Wed, 22 Aug 2007 07:08:12 +0000 (07:08 +0000)]
(bug 10985) Special:DoubleRedirects was omitting "fixed" results when cached, leading to inconsistent paging behaviour - if the query is too expensive to run live, then it shouldn't be run in miser mode either (which is what was happening)
Rob Church [Wed, 22 Aug 2007 06:41:50 +0000 (06:41 +0000)]
(bug 9339) Use wfMsgExt() in OutputPage::showErrorPage() to avoid the old issue with incorrect/inconsistent message transformation and braces
Raimond Spekking [Wed, 22 Aug 2007 06:27:15 +0000 (06:27 +0000)]
* Removing untranslated magic words
* Removing outdated messages too/rebuilding file
Rob Church [Wed, 22 Aug 2007 05:35:40 +0000 (05:35 +0000)]
Add links back to the image in deletion and reversion forms
Rob Church [Wed, 22 Aug 2007 05:30:18 +0000 (05:30 +0000)]
French localisation update, c/o Bertrand GRONDIN
Rob Church [Wed, 22 Aug 2007 05:21:59 +0000 (05:21 +0000)]
Add a class to <strong> for watched links in change lists
Rob Church [Wed, 22 Aug 2007 00:57:41 +0000 (00:57 +0000)]
Wrap
Tim Laqua [Wed, 22 Aug 2007 00:54:32 +0000 (00:54 +0000)]
bugfix noted (10783)
Tim Laqua [Wed, 22 Aug 2007 00:30:16 +0000 (00:30 +0000)]
Fix f/ PNG-24 Alpha Transparency using GDLIB resizing
Ivan Lanin [Wed, 22 Aug 2007 00:02:55 +0000 (00:02 +0000)]
Indonesian (id) localisation updates.
Nick Jenkins [Tue, 21 Aug 2007 04:03:33 +0000 (04:03 +0000)]
Already had brackets as part of the string.
Nick Jenkins [Tue, 21 Aug 2007 03:57:54 +0000 (03:57 +0000)]
Static code analysis housekeeping time... things that could be double-checked are marked with "[Note: some-comment]" :
if-if-else without curly braces [api/ApiQuerySiteinfo.php] --> adding
Unused global declaration: $wgGroupPermissions --> removing
Unused global declaration: $wgEmailConfirmToEdit (line 301) --> removing
Variable $id appears only once (line 1021) --> removing
Variable $m was used before it was defined (line 805) --> defining.
Variable $retval was used before it was defined (line 2346) --> renaming to $result
Variable $rcid appears only once (line 244 of RecentChange.php) --> using this instead of $change [Note: was left over from r24607 refactoring, revert if wrong please]
Unused global declaration: $wgCommandLineMode (line 11) --> removing
Variable $k appears only once (line 132 of ImagePage.php) --> removing.
Variable $info appears only once (line 311 of ImagePage.php) --> removing.
Unused global declaration: $wgTitle (line 569 of ImagePage.php) -> removing.
Variable $handlerParams was used before it was defined (line 616 of Linker.php) --> resolved by Raymond in r24966
Variable $match was used before it was defined (line 1031 of Linker.php) --> defining.
Unused global declaration: $wgEnotifWatchlist (line 253 of UserMailer.php) --> removing
Unused global declaration: $wgShowUpdatedMarker (line 253 of UserMailer.php) --> removing
Variable $img appears only once (line 446 of SpecialUpload.php) --> added definition, defined as null, flagged with @todo [Note: should $img be defined in this context, or is it intended to be null? And should the return value after the hook be checked in some way?]
Unused global declaration: $wgEnableAPI (line 739 of SpecialUpload.php) --> removing.
Unused global declaration: $wgNamespaceProtection (line 1030 of OutputPage.php) --> removing.
Unused global declaration: $wgContLang (line 18 of SpecialWatchlist.php) --> removing.
Unused global declaration: $wgRawHtml (line 269 of SpecialMovepage.php) --> removing.
The value of variable $page was never used (line 331 of SpecialUndelete.php) --> removing line, as $page gets redefined a few lines down.
Variable $synIndex appears only once (line 521 of MagicWord.php) --> commenting out.
Variable $case appears only once (line 539 of MagicWord.php) --> removing from foreach index key usage.
Variable $wgUser appears only once (line 1039 of Title.php) --> adding line to declare as a global, would be null otherwise.
Variable $m was used before it was defined (line 285 of Title.php) --> defining.
Variable $id appears only once (line 1150 of Title.php) --> removing from foreach index key usage.
Variable $subpage appears only once (line 1297 of Title.php) --> commenting out.
Variable $restrictions appears only once (line 1399 of Title.php) --> commenting out.
Variable $mime appears only once (line 210 of filerepo/OldLocalFile.php) --> removing.
Variable $deprefixedName appears only once (line 213 of filerepo/LocalFile.php) --> removing.
Variable $m appears only once (line 541 of filerepo/LocalFile.php) --> removing.
Variable $where appears only once (line 1245 of filerepo/LocalFile.php) --> removing.
Variable $info appears only once (line 1427 of filerepo/LocalFile.php) --> removing.
Variable $rel appears only once (line 138 of filerepo/RepoGroup.php) --> commenting out.
Variable $zone appears only once (line 138 of filerepo/RepoGroup.php) --> commenting out.
Variable $nbytes appears only once (line 208 of media/Generic.php) --> added a return line that uses $nbytes. [Note: I'm assuming that this was the intent]
Variable $offset appears only once (line 201 of SpecialListusers.php) --> removing.
Variable $limit appears only once (line 201 of SpecialListusers.php) --> removing.
Variable $groupTarget appears only once (line 203 of SpecialListusers.php) --> removing.
Unused global declaration: $wgLang (line 74 of SpecialWantedpages.php) --> removing.
Variable $block appears only once (line 244 of SpecialProtectedpages.php) --> removing.
Variable $offset appears only once (line 281 of SpecialProtectedpages.php) --> removing.
Variable $limit appears only once (line 281 of SpecialProtectedpages.php) --> removing.
Unused global declaration: $wgLang (line 30 of FileDeleteForm.php) --> removing.
Unused global declaration: $wgServer (line 30 of FileDeleteForm.php) --> removing.
Aaron Schulz [Tue, 21 Aug 2007 03:21:27 +0000 (03:21 +0000)]
*If no changes, made, we have no new revision. Make $revision NULL, rather than not defined at all, as this spewed errors on no-change rollbacks
Raimond Spekking [Mon, 20 Aug 2007 21:37:48 +0000 (21:37 +0000)]
Fix a regression from r24808:
PHP-Notice: 'Undefined variable:'
Rotem Liss [Mon, 20 Aug 2007 15:54:18 +0000 (15:54 +0000)]
Update.
Rob Church [Mon, 20 Aug 2007 14:57:30 +0000 (14:57 +0000)]
Use an instance variable, not a static one
Rob Church [Mon, 20 Aug 2007 14:49:07 +0000 (14:49 +0000)]
More robust existence/sanity checking
Rob Church [Mon, 20 Aug 2007 14:35:59 +0000 (14:35 +0000)]
As r24950, but for FileDeleteForm
Rob Church [Mon, 20 Aug 2007 14:32:08 +0000 (14:32 +0000)]
* Fix FileRevertForm::getTimestamp() - stupid assumption about archive names :)
* Do date/time adjustments where applicable
* Reverse odd ordering of date/times in messages - time, then date looks cleaner in English
* Remove the commented-out remnants for now
Brion Vibber [Mon, 20 Aug 2007 13:46:08 +0000 (13:46 +0000)]
aaand restore behavior from prior to r24882 on expected input
Brion Vibber [Mon, 20 Aug 2007 13:43:14 +0000 (13:43 +0000)]
Throw an exception for invalid data in expandAttributes() so we get a backtrace and can beat the shit out of whoever did us wrong instead of just seeing a useless PHP warning message or worse yet silently going through without even knowing we probably lost the data we wanted somewhere else in our output
Rob Church [Mon, 20 Aug 2007 13:42:23 +0000 (13:42 +0000)]
Trim some end-of-file whitespace
Raimond Spekking [Mon, 20 Aug 2007 13:17:12 +0000 (13:17 +0000)]
* (bug 10983) Removing Wikipedia hardwired messages
Rob Church [Mon, 20 Aug 2007 13:13:07 +0000 (13:13 +0000)]
(bug 11001) Submit Special:Newpages as a GET, rather than a POST request
Raimond Spekking [Mon, 20 Aug 2007 13:08:45 +0000 (13:08 +0000)]
* (bug 10972) Update Chinese translations
Patch by Shinjiman
Rob Church [Mon, 20 Aug 2007 13:03:00 +0000 (13:03 +0000)]
Bug number for image deletion confirmation stuff
Raimond Spekking [Mon, 20 Aug 2007 10:57:39 +0000 (10:57 +0000)]
* (bug 10972) Update Chinese translations
Patch by Shinjiman
Raimond Spekking [Mon, 20 Aug 2007 10:50:49 +0000 (10:50 +0000)]
* (bug 10977) Update Portuguese translations
Patch by lugusto
Raimond Spekking [Mon, 20 Aug 2007 09:47:17 +0000 (09:47 +0000)]
Update German
Anders Wegge Jakobsen [Mon, 20 Aug 2007 09:31:16 +0000 (09:31 +0000)]
New translations for da
Nick Jenkins [Mon, 20 Aug 2007 08:13:16 +0000 (08:13 +0000)]
Variable $titleString seemed to be used before it was defined - removing.
Nick Jenkins [Mon, 20 Aug 2007 08:04:12 +0000 (08:04 +0000)]
Variable $user seemed to be used before it was defined - removing.
Nick Jenkins [Mon, 20 Aug 2007 07:42:32 +0000 (07:42 +0000)]
Prevent E_STRICT warning:
"Trying to get property of non-object in includes/PageHistory.php on line 257"
Happens because $next === 'unknown', i.e. not an object, on one revision for me with the following fuzz command line test on a local test wiki:
curl --silent --include --globoff -F 'offset'='<<u ' -F 'dir'='prev' 'http://localhost/wiki/index.php?title=Main_Page&action=history' | less
Aaron Schulz [Sun, 19 Aug 2007 16:34:45 +0000 (16:34 +0000)]
*Update page on null revisions made for uploads
Rotem Liss [Sat, 18 Aug 2007 00:06:34 +0000 (00:06 +0000)]
Update for he.
Rob Church [Fri, 17 Aug 2007 21:08:17 +0000 (21:08 +0000)]
Remove some declarations for unused globals...
Rob Church [Fri, 17 Aug 2007 20:53:17 +0000 (20:53 +0000)]
* Confirmation is now required when deleting old versions of files
* Users can now enter comments when deleting old versions of files
Rob Church [Fri, 17 Aug 2007 17:06:33 +0000 (17:06 +0000)]
Make Xml::expandAttributes() a bit more robust against non-array arguments; people keep passing it things it doesn't like :(
Brion Vibber [Fri, 17 Aug 2007 14:39:11 +0000 (14:39 +0000)]
fix regression from r24838 -- lost a '>' char for redirecting 7za output to null
Rob Church [Fri, 17 Aug 2007 13:01:35 +0000 (13:01 +0000)]
* (bug 10971) `aufrom` parameter doesn't work with spaces
* Fix username handling issue with `auprefix` parameter
Usernames are *not* stored in "key" format, and treating them as such will cause various comparisons to misbehave. This was preventing `aufrom` from including the username (as it was supposed to) and would have broken `auprefix` for all comparisons containing spaces.
As a side-effect, both these parameters will now treat underscores as equivalent to spaces.
Raimond Spekking [Thu, 16 Aug 2007 21:36:51 +0000 (21:36 +0000)]
* (bug 10367) Update Kazakh translations
Patch by AlefZet
Rob Church [Thu, 16 Aug 2007 20:52:34 +0000 (20:52 +0000)]
Ditch this; uses old schema, redundant to deleteUnusedAccounts.php
Rob Church [Thu, 16 Aug 2007 20:41:33 +0000 (20:41 +0000)]
(bug 7890) Don't list redirects to special pages in Special:BrokenRedirects
There could be some issues here, since a redirect to a special page that doesn't exist *is* "broken", but I don't think we have a clear, clean means of excluding these at present...
Daniel Cannon [Thu, 16 Aug 2007 07:23:40 +0000 (07:23 +0000)]
Haha .. woops. Left some debugging in there :)
Daniel Cannon [Thu, 16 Aug 2007 07:05:38 +0000 (07:05 +0000)]
* Fix bug with Protected namespace message when protected namespace is NS_MAIN.
* Clean up formatPermissionsErrorMessage .. no point building a list if there's only one item, and it casues lots of grossness on complicated custom messages (removing linebreaks, screwing up formatting, etc.).
Rotem Liss [Thu, 16 Aug 2007 00:24:06 +0000 (00:24 +0000)]
Update and fixes.
Rob Church [Wed, 15 Aug 2007 22:59:38 +0000 (22:59 +0000)]
whitespace
Aaron Schulz [Wed, 15 Aug 2007 22:52:55 +0000 (22:52 +0000)]
Tweak ArticleUpdateBeforeRedirect hook a tad
Rob Church [Wed, 15 Aug 2007 22:43:59 +0000 (22:43 +0000)]
Document hooks in release notes, too, please. Also tweak some odd whitespace usage.
Aaron Schulz [Wed, 15 Aug 2007 22:13:03 +0000 (22:13 +0000)]
*Add ArticleUpdateBeforeRedirect hook, to allow for the page to redirect out differently after editing (needed for flaggedrevs)
*Document ArticleUpdateBeforeRedirect hook
Raimond Spekking [Wed, 15 Aug 2007 22:04:17 +0000 (22:04 +0000)]
* Updating language maintenance scripts
* Updating German localization
* Removing optional, untranslated messages from Danish
Rob Church [Wed, 15 Aug 2007 21:44:58 +0000 (21:44 +0000)]
(bug 8737) Fix warnings caused by incorrect use of `/dev/null` when piping process error output under Windows
Rob Church [Wed, 15 Aug 2007 20:46:51 +0000 (20:46 +0000)]
Coerce mOutputHooks to an array; makes things backwards-compatible with old cached ParserOutput objects
Rob Church [Wed, 15 Aug 2007 19:52:28 +0000 (19:52 +0000)]
(bug 10937) Distinguish overwritten files in upload log; use the `upload/overwrite` action for these
Raimond Spekking [Wed, 15 Aug 2007 19:29:37 +0000 (19:29 +0000)]
Updating language maintenance scripts
Rob Church [Wed, 15 Aug 2007 19:15:41 +0000 (19:15 +0000)]
Reverting r24829; using subtitles leads to an unclear UI, and is a practice that ought to be deprecated
Raimond Spekking [Wed, 15 Aug 2007 19:04:36 +0000 (19:04 +0000)]
* (bug 10946) Update French. Patch by Bertrand GRONDIN.