From: Rob Church <robchurch@users.mediawiki.org>
Date: Tue, 28 Aug 2007 16:59:24 +0000 (+0000)
Subject: * (bug 10985) Compromise solution; strike out resolved cached entries to avoid breaki... 
X-Git-Tag: 1.31.0-rc.0~51618
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=df504390e94e7837556b6b558b6bab02a01ed249;p=lhc%2Fweb%2Fwiklou.git

* (bug 10985) Compromise solution; strike out resolved cached entries to avoid breaking paging - fancier solutions can wait
* Tweak "doubleredirectstext"
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 3b48b4aca8..acba6ca821 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -422,7 +422,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 11082) Fix check for fully-specced table names in Database::tableName
 * (bug 11067) Fix regression in upload conflict thumbnail display
 * (bug 11072) Fix regression in API image history query
-
+* (bug 10985) Resolved cached entries on Special:DoubleRedirects were being
+  supressed, breaking paging - now strikes out "fixed" results
 
 == API changes since 1.10 ==
 
diff --git a/includes/SpecialDoubleRedirects.php b/includes/SpecialDoubleRedirects.php
index a010a2bcc1..6d46fc50a3 100644
--- a/includes/SpecialDoubleRedirects.php
+++ b/includes/SpecialDoubleRedirects.php
@@ -63,6 +63,7 @@ class DoubleRedirectsPage extends PageQueryPage {
 	
 		$fname = 'DoubleRedirectsPage::formatResult';
 		$titleA = Title::makeTitle( $result->namespace, $result->title );
+		$linkA = $skin->makeKnownLinkObj( $titleA,'', 'redirect=no' );
 
 		if ( $result && !isset( $result->nsb ) ) {
 			$dbr = wfGetDB( DB_SLAVE );
@@ -74,13 +75,12 @@ class DoubleRedirectsPage extends PageQueryPage {
 			}
 		}
 		if ( !$result ) {
-			return '';
+			return "<s>{$linkA}</s>\n";
 		}
 
 		$titleB = Title::makeTitle( $result->nsb, $result->tb );
 		$titleC = Title::makeTitle( $result->nsc, $result->tc );
 
-		$linkA = $skin->makeKnownLinkObj( $titleA,'', 'redirect=no' );
 		$edit = $skin->makeBrokenLinkObj( $titleA, "(".wfMsg("qbedit").")" , 'redirect=no');
 		$linkB = $skin->makeKnownLinkObj( $titleB, '', 'redirect=no' );
 		$linkC = $skin->makeKnownLinkObj( $titleC );
diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index 7132c97b24..37a2ec8311 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -1560,7 +1560,7 @@ The [http://meta.wikimedia.org/wiki/Help:Job_queue job queue] length is '''\$7''
 
 'doubleredirects'         => 'Double redirects',
 'doubleredirects-summary' => '', # only translate this message to other languages if you have to change it
-'doubleredirectstext'     => 'Each row contains links to the first and second redirect, as well as the target of the second redirect, which is usually "real" target page, which the first redirect should point to.',
+'doubleredirectstext'     => 'This page lists pages which redirect to other redirect pages. Each row contains links to the first and second redirect, as well as the target of the second redirect, which is usually "real" target page, which the first redirect should point to.',
 
 'brokenredirects'         => 'Broken redirects',
 'brokenredirects-summary' => '', # only translate this message to other languages if you have to change it