From: Roan Kattouw <catrope@users.mediawiki.org>
Date: Mon, 14 Mar 2011 15:16:43 +0000 (+0000)
Subject: (bug 27564) Timestamp of site module embedded in Squid-cached page HTML
X-Git-Tag: 1.31.0-rc.0~31419
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=51b959dcdc3f1275c518822a1c183711f517cebd;p=lhc%2Fweb%2Fwiklou.git

(bug 27564) Timestamp of site module embedded in Squid-cached page HTML
---

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 576be09e5c..b4059fe771 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -2505,10 +2505,12 @@ class OutputPage {
 				}
 				continue;
 			}
-			// Special handling for user and site groups; because users might change their stuff
-			// on-wiki like site or user pages, or user preferences; we need to find the highest
+			// Special handling for the user group; because users might change their stuff
+			// on-wiki like user pages, or user preferences; we need to find the highest
 			// timestamp of these user-changable modules so we can ensure cache misses on change
-			if ( $group === 'user' || $group === 'site' ) {
+			// This should NOT be done for the site group (bug 27564) because anons get that too
+			// and we shouldn't be putting timestamps in Squid-cached HTML
+			if ( $group === 'user' ) {
 				// Get the maximum timestamp
 				$timestamp = 1;
 				foreach ( $modules as $module ) {