From: Sam Reed <reedy@users.mediawiki.org>
Date: Tue, 15 Mar 2011 00:34:44 +0000 (+0000)
Subject: Fix sneaky assignment in conditional
X-Git-Tag: 1.31.0-rc.0~31401
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=4f6d5682c10c6d2561e8a33063664188d97d7b5a;p=lhc%2Fweb%2Fwiklou.git

Fix sneaky assignment in conditional
---

diff --git a/includes/api/ApiLogin.php b/includes/api/ApiLogin.php
index afc353ecd8..6d35304d26 100644
--- a/includes/api/ApiLogin.php
+++ b/includes/api/ApiLogin.php
@@ -72,7 +72,8 @@ class ApiLogin extends ApiBase {
 
 		global $wgCookiePrefix, $wgUser, $wgPasswordAttemptThrottle;
 
-		switch ( $authRes = $loginForm->authenticateUserData() ) {
+		$authRes = $loginForm->authenticateUserData();
+		switch ( $authRes ) {
 			case LoginForm::SUCCESS:
 				$wgUser->setOption( 'rememberpassword', 1 );
 				$wgUser->setCookies( $this->getMain()->getRequest() );