From: Bryan Tong Minh <btongminh@users.mediawiki.org>
Date: Thu, 29 Oct 2009 20:17:23 +0000 (+0000)
Subject: Do a weak boolean comparison against $asyncdownload in order to accept null as false... 
X-Git-Tag: 1.31.0-rc.0~39032
X-Git-Url: http://git.cyclocoop.org/%24action?a=commitdiff_plain;h=3b2c160d7d4e5c7f4cdaafcde54348f8f8b5f46e;p=lhc%2Fweb%2Fwiklou.git

Do a weak boolean comparison against $asyncdownload in order to accept null as false (fixes API upload by URL).
---

diff --git a/includes/upload/UploadFromUrl.php b/includes/upload/UploadFromUrl.php
index d872bb1240..39cfb53392 100644
--- a/includes/upload/UploadFromUrl.php
+++ b/includes/upload/UploadFromUrl.php
@@ -39,7 +39,7 @@ class UploadFromUrl extends UploadBase {
 		global $wgTmpDirectory, $wgPhpCli;
 
 		// check for $asyncdownload request:
-		if( $asyncdownload !== false){
+		if( $asyncdownload ){
 			if( $wgPhpCli && wfShellExecEnabled() ){
 				$this->dl_mode = Http::ASYNC_DOWNLOAD;
 			} else {