User::isAnon() via User::isLoggedIn() has unexpected behavior from an optimization...

diff --git a/includes/SpecialUserrights.php b/includes/SpecialUserrights.php
index a2d78c7..c5ab965 100644 (file)
--- a/includes/SpecialUserrights.php
+++ b/includes/SpecialUserrights.php
@@ -208,7 +208,7 @@ class UserrightsForm extends HTMLForm {
                        $user = UserRightsProxy::newFromName( $database, $name );
                }
                
-               if( !$user || $user->isAnon() ) {
+               if( !$user || $user->getId() == 0 ) {
                        $wgOut->addWikiText( wfMsg( 'nosuchusershort', wfEscapeWikiText( $username ) ) );
                        return null;
                }

diff --git a/includes/User.php b/includes/User.php
index e7bbda9..c22ed5f 100644 (file)
--- a/includes/User.php
+++ b/includes/User.php
@@ -1729,6 +1729,7 @@ class User {
         * Returns true if the user is not an anonymous visitor.
         *
         * @return bool
+        * @fixme "special-case optimization" may fail for an object referring to a user that doesn't exist in the system.
         */
        function isLoggedIn() {
                if( $this->mId === null and $this->mName !== null ) {