9ad4df4bf612cb510575fb1499d7b8e615e84978
3 * Simple script that try to find documented hook and hooks actually
4 * in the code and show what's missing.
6 * This script assumes that:
7 * - hooks names in hooks.txt are at the beginning of a line and single quoted.
8 * - hooks names in code are the first parameter of wfRunHooks.
10 * if --online option is passed, the script will compare the hooks in the code
11 * with the ones at http://www.mediawiki.org/wiki/Manual:Hooks
13 * Any instance of wfRunHooks that doesn't meet these parameters will be noted.
15 * Copyright © Antoine Musso
17 * This program is free software; you can redistribute it and/or modify
18 * it under the terms of the GNU General Public License as published by
19 * the Free Software Foundation; either version 2 of the License, or
20 * (at your option) any later version.
22 * This program is distributed in the hope that it will be useful,
23 * but WITHOUT ANY WARRANTY; without even the implied warranty of
24 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
25 * GNU General Public License for more details.
27 * You should have received a copy of the GNU General Public License along
28 * with this program; if not, write to the Free Software Foundation, Inc.,
29 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
30 * http://www.gnu.org/copyleft/gpl.html
33 * @ingroup Maintenance
34 * @author Antoine Musso <hashar at free dot fr>
37 require_once( __DIR__
. '/Maintenance.php' );
40 * Maintenance script that compares documented and actually present mismatches.
42 * @ingroup Maintenance
44 class FindHooks
extends Maintenance
{
45 public function __construct() {
46 parent
::__construct();
47 $this->mDescription
= 'Find hooks that are undocumented, missing, or just plain wrong';
48 $this->addOption( 'online', 'Check against MediaWiki.org hook documentation' );
51 public function getDbType() {
52 return Maintenance
::DB_NONE
;
55 public function execute() {
58 $documented = $this->getHooksFromDoc( $IP . '/docs/hooks.txt' );
64 $IP . '/includes/actions/',
65 $IP . '/includes/api/',
66 $IP . '/includes/cache/',
67 $IP . '/includes/content/',
68 $IP . '/includes/context/',
69 $IP . '/includes/db/',
70 $IP . '/includes/diff/',
71 $IP . '/includes/filerepo/',
72 $IP . '/includes/filerepo/file/',
73 $IP . '/includes/installer/',
74 $IP . '/includes/interwiki/',
75 $IP . '/includes/logging/',
76 $IP . '/includes/media/',
77 $IP . '/includes/parser/',
78 $IP . '/includes/resourceloader/',
79 $IP . '/includes/revisiondelete/',
80 $IP . '/includes/search/',
81 $IP . '/includes/specials/',
82 $IP . '/includes/upload/',
84 $IP . '/maintenance/',
86 $IP . '/tests/parser/',
87 $IP . '/tests/phpunit/suites/',
91 foreach ( $pathinc as $dir ) {
92 $potential = array_merge( $potential, $this->getHooksFromPath( $dir ) );
93 $bad = array_merge( $bad, $this->getBadHooksFromPath( $dir ) );
96 $potential = array_unique( $potential );
97 $bad = array_unique( $bad );
98 $todo = array_diff( $potential, $documented );
99 $deprecated = array_diff( $documented, $potential );
101 // let's show the results:
102 $this->printArray( 'Undocumented', $todo );
103 $this->printArray( 'Documented and not found', $deprecated );
104 $this->printArray( 'Unclear hook calls', $bad );
106 if ( count( $todo ) == 0 && count( $deprecated ) == 0 && count( $bad ) == 0 )
108 $this->output( "Looks good!\n" );
113 * Get the hook documentation, either locally or from MediaWiki.org
114 * @return array of documented hooks
116 private function getHooksFromDoc( $doc ) {
117 if ( $this->hasOption( 'online' ) ) {
118 return $this->getHooksFromOnlineDoc( );
120 return $this->getHooksFromLocalDoc( $doc );
125 * Get hooks from a local file (for example docs/hooks.txt)
126 * @param $doc string: filename to look in
127 * @return array of documented hooks
129 private function getHooksFromLocalDoc( $doc ) {
131 $content = file_get_contents( $doc );
132 preg_match_all( "/\n'(.*?)'/", $content, $m );
133 return array_unique( $m[1] );
137 * Get hooks from www.mediawiki.org using the API
138 * @return array of documented hooks
140 private function getHooksFromOnlineDoc( ) {
142 $allhookdata = Http
::get( 'http://www.mediawiki.org/w/api.php?action=query&list=categorymembers&cmtitle=Category:MediaWiki_hooks&cmlimit=500&format=php' );
143 $allhookdata = unserialize( $allhookdata );
145 foreach ( $allhookdata['query']['categorymembers'] as $page ) {
146 $found = preg_match( '/Manual\:Hooks\/([a-zA-Z0-9- :]+)/', $page['title'], $matches );
148 $hook = str_replace( ' ', '_', $matches[1] );
153 $oldhookdata = Http
::get( 'http://www.mediawiki.org/w/api.php?action=query&list=categorymembers&cmtitle=Category:Removed_hooks&cmlimit=500&format=php' );
154 $oldhookdata = unserialize( $oldhookdata );
156 foreach ( $oldhookdata['query']['categorymembers'] as $page ) {
157 $found = preg_match( '/Manual\:Hooks\/([a-zA-Z0-9- :]+)/', $page['title'], $matches );
159 $hook = str_replace( ' ', '_', $matches[1] );
163 return array_diff( $allhooks, $removed );
167 * Get hooks from a PHP file
168 * @param $file string Full filename to the PHP file.
169 * @return array of hooks found.
171 private function getHooksFromFile( $file ) {
172 $content = file_get_contents( $file );
174 preg_match_all( '/(?:wfRunHooks|Hooks\:\:run|ContentHandler\:\:runLegacyHooks)\(\s*([\'"])(.*?)\1/', $content, $m );
179 * Get hooks from the source code.
180 * @param $path Directory where the include files can be found
181 * @return array of hooks found.
183 private function getHooksFromPath( $path ) {
185 $dh = opendir( $path );
187 while ( ( $file = readdir( $dh ) ) !== false ) {
188 if ( filetype( $path . $file ) == 'file' ) {
189 $hooks = array_merge( $hooks, $this->getHooksFromFile( $path . $file ) );
198 * Get bad hooks (where the hook name could not be determined) from a PHP file
199 * @param $file string Full filename to the PHP file.
200 * @return array of bad wfRunHooks() lines
202 private function getBadHooksFromFile( $file ) {
203 $content = file_get_contents( $file );
205 # We want to skip the "function wfRunHooks()" one. :)
206 preg_match_all( '/(?<!function )wfRunHooks\(\s*[^\s\'"].*/', $content, $m );
208 foreach ( $m[0] as $match ) {
209 $list[] = $match . "(" . $file . ")";
215 * Get bad hooks from the source code.
216 * @param $path Directory where the include files can be found
217 * @return array of bad wfRunHooks() lines
219 private function getBadHooksFromPath( $path ) {
221 $dh = opendir( $path );
223 while ( ( $file = readdir( $dh ) ) !== false ) {
224 # We don't want to read this file as it contains bad calls to wfRunHooks()
225 if ( filetype( $path . $file ) == 'file' && !$path . $file == __FILE__
) {
226 $hooks = array_merge( $hooks, $this->getBadHooksFromFile( $path . $file ) );
235 * Nicely output the array
236 * @param $msg String: a message to show before the value
237 * @param $arr Array: an array
238 * @param $sort Boolean: whether to sort the array (Default: true)
240 private function printArray( $msg, $arr, $sort = true ) {
244 foreach ( $arr as $v ) {
245 $this->output( "$msg: $v\n" );
250 $maintClass = 'FindHooks';
251 require_once( RUN_MAINTENANCE_IF_MAIN
);